C#: Reduce Type Parameter- and Tuple type location extraction. #20593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the extraction of location information for type parameters and tuple types in the C# extractor by reducing duplicate extractions when types are declared across multiple files. The change introduces a new GetLocations method that respects extraction context and filters locations appropriately.
- Adds context-aware location filtering for type parameters and tuple types
- Updates test cases to verify the improved location extraction behavior
- Consolidates location extraction logic to prevent duplicate extractions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Context.cs | Adds new GetLocations method that filters symbol locations based on context |
| TypeParameter.cs | Updates to use the new context-aware location extraction method |
| TupleType.cs | Updates to use the new context-aware location extraction method |
| locations.ql | Adds new test queries and filtering condition for type parameter and tuple type locations |
| Multiple1.cs | Adds test cases with generic classes and tuple types |
| Multiple2.cs | Adds test cases with generic classes and tuple types |
| Base.cs | Adds additional generic class for testing |
| locations.expected | Updated expected test results reflecting the optimized location extraction |
| 2025-10-08-entity-locations.md | Documents the performance optimization change |
hvitved
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #20581, but for type parameters and tuples types.
With this change, it looks like we have eliminated duplicate extractions of type (source) locations (I checked this for the
monorepo).DCA looks good.